fix(onboarding): name only boards that exist on the rewards slide - #280
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
benibauer3
approved these changes
Sep 25, 2026
benibauer3
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: APPROVE. Mechanical tier (one string plus its guard test); reviewed head 45cbdb5, not behind main.
- The new copy is exactly the wording agreed on #271: "Biggest empire, most land, or top the campaign board. Pick your flex. When a campaign runs, top players get paid in USDT."
IntroScreen.test.tsx: 12 tests pass.- Mutation controls, all red as they should be: putting "priciest plot" back into the rewards slide, putting "priciest" on a different slide, and dropping "campaign board" from the rewards copy.
- Remaining
tycoon/priciestmatches underapps/web/srcare internal code and tests, not player-facing copy.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #271
What changes
The onboarding rewards slide promised a priciest-plot board. That board (TYCOONS) was retired when CAMPAIGN replaced it (#224), so new players were told they could top a board that no longer exists.
Wording, as approved by @benibauer3 on #271:
It names only boards that exist, and "the campaign board" stays true whatever a campaign ranks by. "When a campaign runs … get paid" is unchanged.
Tests
Two copy-guard assertions in
IntroScreen.test.tsx, next to the existing ones:Control: with the old copy restored, both new tests fail (2 failed, 10 passed). With the new copy, 12/12 pass.
Preflight (lint, typecheck, test, as the required check runs them from the repo root): clean.
Before / after
390×844,
/dev/intro-preview, rewards slide (4th dot active):main)Before: "Biggest empire, most pixels, priciest plot." After: "Biggest empire, most land, or top the campaign board." Nothing else on the slide moves. Folder: https://drive.google.com/drive/folders/14JywcvFjTuRf1NNoiIDwsfzIoaUXoac7
🤖 Generated with Claude Code