Optimize entity type representation for strict validation - #2559
Merged
Merged
Conversation
Signed-off-by: jkastner <jkastner@amazon.com>
john-h-kastner-aws
force-pushed
the
enity-lub-non-empty
branch
from
September 10, 2026 19:13
e821e17 to
23b945f
Compare
Coverage ReportHead Commit: Base Commit: Download the full coverage report. Coverage of Added or Modified Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 96.55% Status: PASSED ✅ Details
Coverage of All Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 88.39% Status: PASSED ✅ Details
|
victornicolet
approved these changes
Sep 22, 2026
whonore
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In strict validation, the default and only non-experimental validation mode, we never have non-singleton entity types, but still represent them as a set of entity types. This PR changes the representation from
BTreeSet<EntityType>toNonEmpty<EntityType>to avoid allocating a set for every entity type in strict validation. The single-element case gets stored inline, but in permissive validation we will still heap allocate for the rest. This is possibly less efficient for permissive validation, but should be negligible or even faster for reasonable polices that don't construct massive unions of entities.Measured on strict validation as ~1.2x faster on some simple policies.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).cedar-policy(e.g., addition of a new API).cedar-policy.cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):cedar-docs. PRs should be targeted at astaging-X.Ybranch, notmain.)