Strengthen number validity specification - #11
Merged
Merged
Conversation
john-h-kastner-aws
added this pull request to stack #12
September 9, 2026 15:33
Signed-off-by: jkastner <jkastner@amazon.com>
john-h-kastner-aws
force-pushed
the
ensure-number-validity
branch
from
September 9, 2026 15:34
5d3dc54 to
c061cb5
Compare
victornicolet
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lifts the number validity condition from the tokens to the JSON value by updating
value_matches_specto requirespec_is_valid_json_numberfor number ranges.