Revert "Summoning heavenly logging to smite mismatches on priority assignment" - #3053
Merged
Merged
Conversation
…signment…" This reverts commit aee41c7.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+499
to
+503
| notification.queue_name = choose_queue( | ||
| notification=notification, | ||
| research_mode=service.research_mode, | ||
| priority_queue=get_delivery_queue_for_template(template), | ||
| ) |
jimleroyer
enabled auto-merge (squash)
September 14, 2026 14:41
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A critical unreachable branch leaves the queue/save path dead in post_notifications.py.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Reverts PR #3046 to restore prior notification routing and simulated-notification behavior after production issues.
Changes:
- Removes temporary routing diagnostics.
- Restores queue selection and simulated-notification handling.
- Adds rate-limit persistence assertions.
File summaries
| File | Summary |
|---|---|
tests/app/v2/notifications/test_post_notifications.py |
Verifies rate-limited notifications are not saved. |
app/v2/notifications/post_notifications.py |
Restores simulated-notification handling; contains an unreachable queue/save branch. |
app/service/send_notification.py |
Removes temporary routing diagnostics. |
app/notifications/rest.py |
Reverts logging and variable naming changes. |
app/notifications/process_notifications.py |
Restores queue-selection logic and removes diagnostics. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+498
to
+507
| if not simulated: | ||
| notification.queue_name = choose_queue( | ||
| notification=notification, | ||
| research_mode=service.research_mode, | ||
| priority_queue=get_delivery_queue_for_template(template), | ||
| ) | ||
| db_save_and_send_notification(notification) | ||
|
|
||
| else: | ||
| current_app.logger.debug("POST simulated notification for id: {}".format(notification.id)) |
Open
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3046
We have an issue with this one as we deployed to production and likely took code paths it did not in staging env.