Conversation
andrewleith
reviewed
Sep 3, 2026
andrewleith
left a comment
andrewleith
left a comment
Member
There was a problem hiding this comment.
Can you still run the smoke tests without that?
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes cleanly remove long-lived AWS keys with no remaining references in code and preserve existing OIDC-based authentication in the workflow.
Pull request overview
This PR removes long-lived AWS access key usage from the repository’s CI workflow and smoke-test configuration, standardizing on GitHub Actions OIDC and the default AWS credential provider chain.
Changes:
- Removed the
STAGING_AWS_ACCESS_KEY_ID/STAGING_AWS_SECRET_ACCESS_KEYcredentials configuration step from the Docker deploy GitHub Actions workflow. - Removed the
SMOKE_AWS_ACCESS_KEY_ID/SMOKE_AWS_SECRET_ACCESS_KEYfallback path from smoke tests so boto3 always uses ambient credentials.
File summaries
| File | Description |
|---|---|
| tests_smoke/smoke/common.py | Removes explicit access-key environment fallback and always uses the default boto3 credential chain. |
| .github/workflows/docker.yaml | Removes static staging AWS access key configuration, relying on the existing OIDC role assumption for AWS auth. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove long-lived staging AWS access-key usage from the API repository's test paths.
Changes
STAGING_AWS_ACCESS_KEY_ID/STAGING_AWS_SECRET_ACCESS_KEYcredential step from.github/workflows/docker.yaml. The job already authenticates to ECR through GitHub Actions OIDC.SMOKE_AWS_ACCESS_KEY_ID/SMOKE_AWS_SECRET_ACCESS_KEYfallback fromtests_smoke/smoke/common.py. Smoke tests now always use the ambient AWS credential provider chain, including OIDC-provided credentials.Validation
git diff --checkpassedTerraform IAM-user deactivation should be performed separately after this change is deployed and staging behavior is observed, so any remaining consumers can be identified without disabling the identity prematurely.