New feat banner - #2761
New feat banner#2761amazingphilippe wants to merge 0 commit into
Conversation
🧪 Review environmenthttps://gga2ussysqkwwumchop464ysei0wbifw.lambda-url.ca-central-1.on.aws/ |
🧪 Review environmenthttps://yn5etz6ycxbfyjv6gj37vjksfi0mtlyj.lambda-url.ca-central-1.on.aws/ |
smcmurtry
left a comment
smcmurtry
left a comment
There was a problem hiding this comment.
The new component looks good! Could we leave leave it off the template page until we get section links working on the "new features" page?
| {{ new_feature( | ||
| title=_("Upload attachments without the API"), | ||
| cta=_("About file attachments"), | ||
| cta_link="/new-features", |
There was a problem hiding this comment.
It would be better if we could link directly to the relevant section on this page with a /new-features#ui-file-attachments link. But it looks like that page doesn't have ids on each section. Also the formatting of the new-features page looks a bit off. Not really related to the new component, but it would be good to fix that before this goes live.
| url_for('main.template_attachment_status', service_id=current_service.id, template_id=template.id), | ||
| url_for('main.download_template_attachment', service_id=current_service.id, template_id=template.id) | ||
| ) }} | ||
| {{ new_feature( |
There was a problem hiding this comment.
Could you move this above the "Attached files" component? It seems more natural to me that you would read the "new feature" banner before you see the new feature.
There was a problem hiding this comment.
I don't think we need this new script - if we can remember to run the script we can remember to do a "find in project" for new_feature( banners and check the lifespans.
c3b9d2d to
70c7df2
Compare
2 participants
Summary | Résumé
Adding a prototype for a new-feature banner that we can anchor to any part of the UI, or insert as a flowing container where needed.
How it works:
Test instructions | Instructions pour tester la modification