Evaluate registration and login as anonymous-then-authenticated flows#23
Merged
Conversation
Filter the registration attempt before the account is created ($registration / $attempted), and report an invalid attempt as $failed, resolving any existing user via matching_user_id. Filter the login attempt ($login / $attempted) before checking credentials, then risk-assess a successful login ($succeeded) on the same request token, sending a failed login to the filter endpoint ($failed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filters the registration attempt before the account is created (
$registration/$attempted) and blocks the sign-up on adenyverdict. An invalid attempt (e.g. an email already taken) is reported to the Filter API as$failed, resolving any existing user viamatching_user_id.Filters the login attempt (
$login/$attempted) while the visitor is still anonymous, before credentials are checked, then risk-assesses a successful login ($succeeded) reusing the same request token. A failed login is sent to the Filter API as$failed(withmatching_user_idwhen the email matches an existing user).