Repository navigation
refactor: organize mint RPC server and CLI by service - #2545
Merged
thesimplekid merged 2 commits intoSep 22, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2545 +/- ##
==========================================
- Coverage 80.06% 80.05% -0.01%
==========================================
Files 387 382 -5
Lines 107098 107098
==========================================
- Hits 85744 85742 -2
- Misses 21354 21356 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
@cdk-bot review |
Collaborator
orangeshyguy21
force-pushed
the
mint-rpc-service-modules
branch
from
September 16, 2026 19:46
1df0979 to
716760d
Compare
Collaborator
Move proto/server.rs into a server/ directory with one file per gRPC service, mirroring the proto layout. mod.rs keeps the struct, builders, mutation guard, and start/stop; each service file takes its trait impl plus the helpers only it calls. Pure move: no signature, behavior, or test-logic changes.
Collapse the flat subcommand files into one module per service, matching the server split and the proto layout. The re-exported symbol set is unchanged, so the CLI binary and its command surface are untouched.
thesimplekid
force-pushed
the
mint-rpc-service-modules
branch
from
September 22, 2026 15:29
716760d to
134535b
Compare
thesimplekid
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Organizes the mint management RPC server and CLI into one module per service: info, keyset, payment method, quote, and wallet.
Splits
proto/server.rsinto service modules and groups CLI subcommands following the existing wallet module pattern. No behavior, API, or CLI command changes.Completes the server modularization step in #2326, following the legacy RPC removal.
Notes to the reviewers
server/mod.rs. Service-specific helpers and tests move alongside their implementations.Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)