[j-kon]

Summary

This PR exposes existing wallet mint quote query methods through the FFI Wallet.

Recent FFI work exposed quote recovery/sync methods such as check_all_mint_quotes and mint_unissued_quotes. This PR adds the complementary query methods so generated bindings can inspect active and unissued mint quotes.

Changes

• Add Wallet::get_active_mint_quotes to crates/cdk-ffi
• Add Wallet::get_unissued_mint_quotes to crates/cdk-ffi
• Convert core return values into existing FFI-compatible quote types
• Keep generated binding outputs out of this PR

Testing

• cargo fmt
• cargo test -p cdk-ffi

Partially addresses #1767

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.83%. Comparing base (cc02d2d) to head (6b44700).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2217      +/-   ##
==========================================
+ Coverage   75.81%   75.83%   +0.02%     
==========================================
  Files         369      369              
  Lines       89594    89615      +21     
==========================================
+ Hits        67924    67958      +34     
+ Misses      21670    21657      -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[j-kon]

@cdk-bot review

[asmogo]

Hi @j-kon. Thanks for extending this. Do you need those functions for a specific use case? There are already similar functions available in the database trait, which are exported to the FFI layer.

cdk/crates/cdk-ffi/src/database.rs

Line 42 in 57b2a6f

async fn get_mint_quotes(&self) -> Result<Vec<MintQuote>, FfiError>;

and

cdk/crates/cdk-ffi/src/database.rs

Line 46 in 57b2a6f

async fn get_unissued_mint_quotes(&self) -> Result<Vec<MintQuote>, FfiError>;

[j-kon]

Hi @j-kon. Thanks for extending this. Do you need those functions for a specific use case? There are already similar functions available in the database trait, which are exported to the FFI layer.

cdk/crates/cdk-ffi/src/database.rs

Line 42 in 57b2a6f

async fn get_mint_quotes(&self) -> Result<Vec<MintQuote>, FfiError>;

and

cdk/crates/cdk-ffi/src/database.rs

Line 46 in 57b2a6f

async fn get_unissued_mint_quotes(&self) -> Result<Vec<MintQuote>, FfiError>;

Thanks, I checked the existing database methods.

The wallet methods add wallet-scoped filtering beyond the raw database queries:

• get_active_mint_quotes limits results to the wallet’s current mint and unit, excludes issued quotes, and excludes expired quotes.
• get_unissued_mint_quotes limits stored unissued quotes to the current mint and unit.

The use case I had in mind is a Flutter wallet pending-deposits view, where the app can request quotes belonging to that specific wallet context without reimplementing CDK’s filtering rules in Dart.

That said, I understand the database API already exposes the underlying data. Would you prefer keeping these wallet-level convenience methods, narrowing the PR to only get_active_mint_quotes, or using the database methods from the binding instead?

[cdk-bot]

Verified findings approved for disclosure:

• FFI doc for get_unissued_mint_quotes misstates return semantics (includes issued bolt12 and expired quotes) (low) - see inline comment

[j-kon]

Hi @asmogo, I noticed #2479 is now restructuring the wallet and FFI APIs around resumable workflows.

Given that direction, I wanted to check before rebasing this PR. The original use case here was a Flutter pending-deposits view, where the app needs wallet-scoped visibility into active/unissued mint quotes without reimplementing CDK filtering rules.

With the new API in #2479, would you prefer that use case to go through operations() / resume_mint() / synchronization instead of exposing these quote-query methods directly?

If so, I’m happy to close this PR rather than rebase an API that is being replaced. If these helpers are still useful on the new surface, I can adapt the contribution to the new architecture.

[j-kon]

Closing this for now in light of the ongoing wallet and FFI refactoring in #2479. Once the new resumable operations architecture lands, I will revisit whether these query helpers or equivalent operation-scoped inspection methods are needed on the new surface. Thanks!