Skip to content

overlord: type SnapSetup and SnapState to return naming.InstanceName and naming.SnapName - #17519

Open
maykathm wants to merge 3 commits into
canonical:masterfrom
maykathm:SNAPDENG-35739-convert-snapstate-snapsetup
Open

overlord: type SnapSetup and SnapState to return naming.InstanceName and naming.SnapName#17519
maykathm wants to merge 3 commits into
canonical:masterfrom
maykathm:SNAPDENG-35739-convert-snapstate-snapsetup

Conversation

@maykathm

Copy link
Copy Markdown
Contributor

Requires #17496 (first commit is from that PR and can be ignored)

@maykathm maykathm added the Skip spread Indicate that spread job should not run label Aug 24, 2026
@github-actions github-actions Bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Aug 24, 2026
@github-actions

Copy link
Copy Markdown

Mon Aug 24 15:04:58 UTC 2026

Spread tests skipped

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.56659% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.89%. Comparing base (f12eaba) to head (97ec40b).

Files with missing lines Patch % Lines
overlord/snapstate/handlers.go 69.37% 16 Missing and 33 partials ⚠️
overlord/ifacestate/handlers.go 85.18% 0 Missing and 4 partials ⚠️
overlord/snapstate/autorefresh.go 81.25% 1 Missing and 2 partials ⚠️
overlord/snapstate/snap.go 93.75% 1 Missing and 2 partials ⚠️
overlord/snapstate/snapstate.go 94.54% 0 Missing and 3 partials ⚠️
overlord/snapstate/handlers_components.go 86.66% 0 Missing and 2 partials ⚠️
overlord/devicestate/handlers_gadget.go 75.00% 0 Missing and 1 partial ⚠️
overlord/ifacestate/helpers.go 66.66% 0 Missing and 1 partial ⚠️
overlord/ifacestate/ifacestate.go 66.66% 0 Missing and 1 partial ⚠️
overlord/servicestate/quota_handlers.go 50.00% 0 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17519      +/-   ##
==========================================
+ Coverage   78.83%   78.89%   +0.05%     
==========================================
  Files        1409     1400       -9     
  Lines      198150   198130      -20     
  Branches     2502     2502              
==========================================
+ Hits       156218   156320     +102     
+ Misses      32553    32419     -134     
- Partials     9379     9391      +12     
Flag Coverage Δ
unittests 78.89% <82.56%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Documentation -auto- Label automatically added which indicates the change needs documentation Skip spread Indicate that spread job should not run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant