Conversation
sbrunner
reviewed
Jul 23, 2026
mki-c2c
marked this pull request as ready for review
July 31, 2026 17:47
Member
Author
|
@sbrunner |
sbrunner
approved these changes
Aug 11, 2026
Member
Author
|
@sbrunner feel free to merge if you feel the failed CI item is OK. |
mki-c2c
enabled auto-merge
September 8, 2026 09:34
mki-c2c
disabled auto-merge
September 8, 2026 09:34
Member
Author
|
@sbrunner I can't merge, but the errors are OK for me, nothing related to changes, essentially warnings for missing copyright notice. Could you please merge for me ? |
Member
|
Can you do a rebase to be on the latest version of master and also squash the commits? |
Add delay_startup option to SQLAlchemyHandler initialization.
From the artifact of the previous workflow run
Added usage instructions for configuring SQLAlchemyLogger with Gunicorn.
From the artifact of the previous workflow run
production.ini file seems to follow python dict conventions
Add type hints to start and _start methods
From the artifact of the previous workflow run
Co-authored-by: Stéphane Brunner <sbrunner@users.noreply.github.com>
Co-authored-by: Stéphane Brunner <sbrunner@users.noreply.github.com>
Co-authored-by: Stéphane Brunner <sbrunner@users.noreply.github.com>
Co-authored-by: Stéphane Brunner <sbrunner@users.noreply.github.com>
Co-authored-by: Stéphane Brunner <sbrunner@users.noreply.github.com>
Co-authored-by: Stéphane Brunner <sbrunner@users.noreply.github.com>
mki-c2c
force-pushed
the
gunicorn_sqlalchemylogger
branch
from
September 8, 2026 13:06
d27b91a to
113580c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forking server gunicorn will start the bachground thread of the sqlalchemylogger in the main process by default
synchronisation will not work correctly.
This patch enables delaying the logger startup to move it to a post_fork hook if needed