fix: resolve r4.1 release review findings (#285, #286, #287, #289)

[albertoramosmonagas]

What type of PR is this?

• correction
• tests

What this PR does / why we need it:

Fixs addressing findings from the Release r4.1 review (#284).

• Fixes sim-swap description overclaims optionality for /check and /retrieve-date #285, sim-swap-subscriptions description not updated for 0.4.0 #286, Documentation regressions: broken RFC 3339 link, dropped example, wrong-domain description #287, /retrieve-age-band has no test definitions #289

Special notes for reviewers:

• Issues SimSwapAgeBand schema can't express valid limits for the 111 sentinel (S-310/S-311 in #276) #277 (SimSwapAgeBand schema constraints @KeldaAnders) & Cross-API consistency issues between sim-swap and sim-swap-subscriptions #288 (cross-API consistency) remain open for follow-up as they require broader architectural decisions and group consensus

Changelog input

release-note
SimSwap r4.1 release review corrections:
- Clarified mandatory vs optional operation support (#285)
- Updated API documentation for v0.4.0 with pagination, credentials, and event structure details (#286)
- Fixed documentation regressions: RFC 3339 link, missing example, incorrect description (#287)
- Added comprehensive test definitions for retrieve-age-band operation (#289)

[bigludo7]

LGTM

[hdamker]

See suggestions below

[hdamker]

"albertoramosmonagas force-pushed the fix/r4.1-release-review-findings branch from 2655d4c to dc8084c"

Force push should be a last resort on public PRs.

[hdamker]

"Fixes #284, #285, #286, #287, #289":

That would close only #284, but it shouldn't close it, as not all Sub Issues are addressed with this PR.

[albertoramosmonagas]

Move to draft to work on the suggested changes

[albertoramosmonagas]

All changes applied.

[bigludo7]

LGTM - Thanks @albertoramosmonagas

[bigludo7]

@hdamker please give me your thumb up if OK for you ;)

[hdamker]

Compared to the version I reviewed (commit a0c948f), five scenarios in sim-swap-retrieveSimSwapAgeBand.feature have no surviving replacement — not consolidated, just gone. Both sibling files (sim-swap-checkSimSwap.feature, sim-swap-retrieveSimSwapDate.feature) still cover all of these:

• 401.2_expired_access_token
• 401.3_invalid_access_token
• 404 IDENTIFIER_NOT_FOUND (both the standalone and C02.02 copies are gone)
• C02.03_unnecessary_phone_number

See my suggestions below. Additionally a suggestion for the band 10 scenario.

[albertoramosmonagas]

Compared to the version I reviewed (commit a0c948f), five scenarios in sim-swap-retrieveSimSwapAgeBand.feature have no surviving replacement — not consolidated, just gone. Both sibling files (sim-swap-checkSimSwap.feature, sim-swap-retrieveSimSwapDate.feature) still cover all of these:

• 401.2_expired_access_token
• 401.3_invalid_access_token
• 404 IDENTIFIER_NOT_FOUND (both the standalone and C02.02 copies are gone)
• C02.03_unnecessary_phone_number

See my suggestions below. Additionally a suggestion for the band 10 scenario.

Thanks @hdamker for the suggestions, they were very helpful. I've try to cover everything but please let me know if I missed anything.

CC: @bigludo7

[hdamker]

@albertoramosmonagas Two issues from the latest push (ef5a48f + d672361):

sim-swap.yaml — the retrieveSimSwapAgeBand description got corrupted applying the suggestion: the "Transient backend or data-source failures..." sentence is now cut off mid-word ("...Transient"), followed by the whole paragraph repeated a second time. The original redundant "This operation is OPTIONAL... 501 NOT_IMPLEMENTED" sentence is also still there.

Feature file — my suggested scenarios and the separate manual commit both landed, so several tags are now duplicated: 401.2_expired_access_token and 401.3_invalid_access_token each appear twice, and the 404-not-found / unnecessary-identifier cases each appear twice under two different tag names (C02.02/404.1, C02.03/422.3).

Could you dedupe the feature file (one copy of each, in my suggestions I kept the 4xx.y ) and fix the sim-swap.yaml paragraph back to one clean copy?

[albertoramosmonagas]

@albertoramosmonagas Two issues from the latest push (ef5a48f + d672361):

sim-swap.yaml — the retrieveSimSwapAgeBand description got corrupted applying the suggestion: the "Transient backend or data-source failures..." sentence is now cut off mid-word ("...Transient"), followed by the whole paragraph repeated a second time. The original redundant "This operation is OPTIONAL... 501 NOT_IMPLEMENTED" sentence is also still there.

Feature file — my suggested scenarios and the separate manual commit both landed, so several tags are now duplicated: 401.2_expired_access_token and 401.3_invalid_access_token each appear twice, and the 404-not-found / unnecessary-identifier cases each appear twice under two different tag names (C02.02/404.1, C02.03/422.3).

Could you dedupe the feature file (one copy of each, in my suggestions I kept the 4xx.y ) and fix the sim-swap.yaml paragraph back to one clean copy?

Thanks for catching those issues. I've just fixed both in the last 2 commits. Apologies for the extended discussion. Please let me know if anything else needs attention.

[bigludo7]

LGTM

[hdamker]

@albertoramosmonagas thanks for fixing the regressions. Look good to me now!