net: use IPPROTO_IPV6 for IPV6_MULTICAST_HOPS - #1662
Open
RajaBabu15 wants to merge 2 commits into
Open
Conversation
Both backends were passing IPPROTO_IP. Add a UDP set/get round-trip so this can't hide behind NOPROTOOPT on a stream socket. Fixes bytecodealliance#1660
The old assert expected 0 because get used the wrong protocol level. Linux (and NetBSD) report 1 once the option is queried correctly, same as IP_MULTICAST_TTL.
Author
|
ubuntu-22.04 and the dragonfly job are the existing nightly/tempfile rustix-1.1.4 break and #1648, not this. use-libc jobs are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPV6_MULTICAST_HOPS is an IPPROTO_IPV6 option. Both backends were
passing IPPROTO_IP, so get/set either failed with NOPROTOOPT or
didn't actually set the hop limit.
The existing test only read the default and treated NOPROTOOPT/INVAL
as success. Added a UDP set/get round-trip, and OPNOTSUPP on the
stream-socket get (macOS returns that once the level is correct).
Fixes #1660