fix: cache committed datatypes as a live hid_t, not a serialized buffer - #1
Closed
brtnfld wants to merge 1 commit into
Closed
fix: cache committed datatypes as a live hid_t, not a serialized buffer#1brtnfld wants to merge 1 commit into
brtnfld wants to merge 1 commit into
Conversation
H5_daos_dtype_t holds a live, open hid_t for its committed datatype, matching how H5_daos_attr_t, H5_daos_dset_t, and H5_daos_map_t already cache their stored datatypes. These IDs are legitimate app-level HDF5 IDs regardless of whether a VOL connector considers them internal bookkeeping, so H5Fget_obj_count(H5F_OBJ_ALL, ...) counting them is correct behavior, not something to avoid.
Owner
Author
|
Folded into HDFGroup#73 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
H5_daos_dtype_tnow holds a live, openhid_tfor its committed datatype again, matching howH5_daos_attr_t,H5_daos_dset_t, andH5_daos_map_talready cache their stored datatypes.H5Fget_obj_count(H5F_OBJ_ALL, ...)counting them is correct behavior, not something to avoid.Test plan
H5Ocopyof a committed datatype all still workH5Fget_obj_count(H5F_OBJ_ALL, ...)includes open committed-datatype IDs as expected