to_restart: fix _FillValue incompatibility#349
Merged
Conversation
This fixes BOUT++ crashing on running restarts. Unlike the boutdata tool, the xBOUT restart tool let Xarray set the _FillValue attribute to NaN by default. When BOUT++ reads restart files, it rewrites all the attributes including this one, but Xarray doesn't allow _FillValue to be redefined, leading to a crash at launch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes BOUT++ crashing when running with restart files produced by
to_restart().Unlike the boutdata tool, the xBOUT restart tool let Xarray set the
_FillValueattribute on all variables to NaN, which is default behaviour. When BOUT++ reads restart files, it rewrites all the attributes, which includes_FillValue. However, this is a special attribute and NetCDF doesn't allow it to be redefined, leading to a crash at launch.