Keep Zed layer replays cohort-correct - #14
Draft
gauravtiwari wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The layer plans themselves are already on
main, but two later proof runs exposed benchmark-boundary failures:fail-on-cache-missrejected target-only and combined jobs when a dependency archive missed even though the target snapshot restored. The workflow already verifies the target-layer hit explicitly, so aggregate strict-miss handling was testing the wrong boundary.native_tool: null; the report treated that as an object and failed after both builds had succeeded.The matrix also defaulted to the moving rolling source while its plan tags stayed fixed. A later manual dispatch could therefore restore an older cohort in the lane labelled cold.
cargo-layer-source.envnow owns the reviewed matrix pair (4e8057d…→d4010e9…), whilebenchmark-source.envcontinues to own the rolling chain.No upstream Cargo command, runner architecture, runner label policy, or QEMU setting changes.
Verification
python3 -m unittest discover -s test -v(9 tests)python3 scripts/verify-zed-release-recipe.py upstreamactionlint .github/workflows/*.ymlgit diff --checkA full fresh-runner matrix will be dispatched on this branch using the new cache cohort.