Skip to content

[PM-40623] Add ProducesResponseType to fix SDK server bindings#8046

Merged
eliykat merged 1 commit into
mainfrom
ac/pm-40623/ac-clients-update-invite-link-client
Jul 23, 2026
Merged

[PM-40623] Add ProducesResponseType to fix SDK server bindings#8046
eliykat merged 1 commit into
mainfrom
ac/pm-40623/ac-clients-update-invite-link-client

Conversation

@eliykat

@eliykat eliykat commented Jul 23, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-40623

📔 Objective

The SDK server bindings don't know what type IResult is. Minimal APIs will fix this automagically, but for now add the ProducesResponseType annotation to each endpoint to fix this.

📸 Screenshots

@eliykat
eliykat requested a review from r-tome July 23, 2026 10:08
@eliykat
eliykat requested a review from a team as a code owner July 23, 2026 10:08
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a single-file change to OrganizationInviteLinksController.cs that adds ProducesResponseType annotations to each endpoint so the SDK server bindings can resolve the otherwise-opaque IResult return types. Verified each annotation's declared type and status code matches the corresponding endpoint's TypedResults return value, including Created for Create and NoContent for the payload-less Delete. This is a documentation/OpenAPI-only change with no security, correctness, breaking-change, or performance impact.

No findings.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.48%. Comparing base (6f0b248) to head (9cd157b).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8046      +/-   ##
==========================================
+ Coverage   62.46%   62.48%   +0.01%     
==========================================
  Files        2297     2298       +1     
  Lines       99981   100025      +44     
  Branches     9020     9022       +2     
==========================================
+ Hits        62456    62497      +41     
- Misses      35346    35349       +3     
  Partials     2179     2179              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eliykat eliykat added ai-review Request a Claude code review t:tech-debt Change Type - Tech debt labels Jul 23, 2026
@eliykat
eliykat merged commit 0d60363 into main Jul 23, 2026
51 of 53 checks passed
@eliykat
eliykat deleted the ac/pm-40623/ac-clients-update-invite-link-client branch July 23, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants