[deps] Auth: Update Duende.IdentityServer to v8#8025
Conversation
|
Internal tracking:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8025 +/- ##
===========================================
- Coverage 62.42% 14.88% -47.55%
===========================================
Files 2289 1386 -903
Lines 99712 60194 -39518
Branches 9004 4784 -4220
===========================================
- Hits 62250 8957 -53293
- Misses 35290 51086 +15796
+ Partials 2172 151 -2021 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
463f578 to
d3ed1a2
Compare
🤖 Bitwarden Claude Code ReviewOverall Assessment: REQUEST CHANGES This Renovate PR performs a major version bump of Code Review Details
Dependency Changes
Lock file hygiene is clean: the manifest and all 58 lock files are consistently updated to 8.0.2 with no leftover 7.4.6 references. The new transitive |
| <PackageReference Include="SendGrid" Version="[9.29.3]" /> | ||
| <PackageReference Include="Serilog.Extensions.Logging.File" Version="[3.0.0]" /> | ||
| <PackageReference Include="Duende.IdentityServer" Version="[7.4.6]" /> | ||
| <PackageReference Include="Duende.IdentityServer" Version="[8.0.2]" /> |
There was a problem hiding this comment.
Details
This is a SemVer major upgrade of a security-critical auth/OIDC dependency, and CI reflects breaking changes reaching compiled code:
Run tests— failBuild Docker images (Identity, ...)— failBuild Docker images (Sso, ...)— fail
Identity and Sso are the two services most tightly coupled to IdentityServer (~95 dependent files), so these failures point to v8 API breaking changes that must be migrated in code before this can merge, not just a version string bump.
The PR description (Renovate template) contains no breaking-change or migration notes. Duende publishes a v7→v8 migration guide — the breaking changes should be evaluated and the necessary code updates made in this PR so the Identity/Sso builds and test suite pass.
Note: the v8 licensing enforcement is already accounted for via options.LicenseKey in src/Identity/Utilities/ServiceCollectionExtensions.cs, so that specific new requirement is not the blocker.
Reference: https://bitwarden.atlassian.net/wiki/spaces/APPSEC/pages/2774466657/Dependency+Review+and+Approval
This PR contains the following updates:
[7.4.6]→[8.0.2]Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.