Skip to content

ci: Remove ignoring logs on upload to TestFlight#2864

Merged
fedemkr merged 2 commits into
mainfrom
upload-testflight-verbose
Jul 20, 2026
Merged

ci: Remove ignoring logs on upload to TestFlight#2864
fedemkr merged 2 commits into
mainfrom
upload-testflight-verbose

Conversation

@fedemkr

@fedemkr fedemkr commented Jul 7, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

📔 Objective

Remove ignoring logs when uploading to TestFlight to help diagnosis.

@fedemkr
fedemkr requested a review from a team as a code owner July 7, 2026 16:38
@github-actions github-actions Bot added the t:ci Change Type - Updates to automated workflows label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: REQUEST CHANGES

This PR adds a --verbose flag to the xcrun altool TestFlight upload step in .github/workflows/_build-any.yml to aid diagnosis. The change is small and CI-only, but it introduces a shell syntax error in the modified line.

Code Review Details
  • ❌ : Malformed line continuation (\ \) passes a stray argument to altool, breaking the upload command
    • .github/workflows/_build-any.yml:304

Comment thread .github/workflows/_build-any.yml Outdated
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.02%. Comparing base (5569548) to head (2c5c1dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2864      +/-   ##
==========================================
- Coverage   81.28%   79.02%   -2.27%     
==========================================
  Files        1027     1150     +123     
  Lines       66123    73418    +7295     
==========================================
+ Hits        53748    58016    +4268     
- Misses      12375    15402    +3027     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Removed error handling and output echo for xcrun altool upload.

@vvolkgang vvolkgang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fedemkr
fedemkr merged commit da0755e into main Jul 20, 2026
22 checks passed
@fedemkr
fedemkr deleted the upload-testflight-verbose branch July 20, 2026 14:24
@fedemkr fedemkr changed the title ci: Test verbose upload to TestFlight ci: Remove ignoring logs on upload to TestFlight Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants