jQuery is not defined

[kdillon]

Upon funcunit import, we get... "

VM180:9958 Uncaught ReferenceError: jQuery is not defined
at :9958:21
at global.define (:73:36)
at :9955:1
(anonymous) @ VM180:9958
global.define @ VM180:73
(anonymous) @ VM180:9955

"

This could be a regression of #187 (similar syndrome), but I think jQuery is undefined prior to the failure moment described in 187.

Chasen suspects it might be related to changeset: #230
... and I think he's on to something.

[chasenlehara]

A little more info… here’s what the built file looks like:

define('global', function (require, exports, module) {
    require('funcunit');
    var FuncUnit = window.FuncUnit || {};
    window.jQuery = jQuery;
    module.exports = FuncUnit;
});

I put a debugger statement before window.jQuery = jQuery to see the value of jQuery

• 3.5.0: jQuery is undefined
• 3.6.2: jQuery isn’t defined, hence the reference error

[matthewp]

Sounds like the global module is wrong then. I don't know where this module is but if it wants to set jQuery on the window it should be importing it from within FuncUnit now.

Having jQuery be a global in the non-global build was a longstanding cause of pain for people.

[chasenlehara]

Here’s that issue I think: Do not set window.jQuery

I think this is the global module: https://github.com/bitovi/funcunit/blob/master/global.js

Is the solution to add var jQuery = require("funcunit/browser/jquery"); to the global build?

Or should this line:

funcunit/global.js

Line 4 in bbc3c16

window.jQuery = jQuery;

…be changed to:

window.jQuery = FuncUnit.jQuery;

…or should the global build not set window.jQuery at all?

I’m not familiar with how FuncUnit is supposed to work with its own version of jQuery vs. imported versions, hence the uncertainty on my end. 😬

[matthewp]

I'd say not set window.jQuery at all. FuncUnit uses it internally, but uses its own version now that is gets through the module loader. So I don't think setting window.jQuery is a good idea. The reason for getting rid of it was that it interfered with other jQuerys on the page.