Add the existing pibot environment to official releases - #65
Draft
abcpibot wants to merge 1 commit into
Draft
Conversation
FluidDial already carries [env:pibot] for the PiBot Pendant V4, but the release workflow and manifest still only ship m5dial and cyddial, so no prebuilt pibot image is published. Build pibot alongside the other two and offer it in the manifest as a second esp32 firmware variant next to the CYD build. No source, board or platformio.ini changes are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FluidDial already carries
[env:pibot]for the PiBot Pendant V4 (added in #51, with the FT5x06 polling fix in #61), butbuildRelease.ymlandmanifest.pystill only shipm5dialandcyddial. So there is no prebuilt PiBot image in an official release, and PiBot users have to build from source or get a binary elsewhere.This adds the environment that already exists to the release, nothing more.
Changes
.github/workflows/buildRelease.yml— build loopm5dial cyddial→m5dial cyddial pibotmanifest.py— copypibotinto the release directory, and offer it as a second esp32 firmware variant alongside the CYD buildNo source, board, or
platformio.inichanges:[env:pibot]is already there and already extendsenv:cyd_base, so it needs no new toolchain or partition setup.Manifest layout
PiBot lands next to CYD under the existing esp32 node; M5Dial is untouched under esp32s3.
Verification
Ran the exact build loop and
manifest.pyfrom this branch in CI (release/deploy steps omitted, since those need repo secrets):release/containsm5dial.bin(8.0M),cyddial.bin(4.0M),pibot.bin(4.0M),manifest.jsonmanifest.jsonvalidates: every image referenced by an installable exists on disk and its recorded size matches the filepibotis reachable as an installableThe resulting
pibot.binis a complete merged image (0xE9bootloader at0x1000, flashable at0x0), and an equivalent build has been flash-tested on PiBot Pendant V4 hardware.