emulationstation-standalone: read global.videooutput2 default via -master too

[Pyohwan]

If screen2 is unset, the script auto-picks a second output. It decides this by checking global.videooutput2 with the plain lookup, but that lookup only sees user overrides in /userdata/system/batocera.conf. It doesn't see sysconfig-level board defaults. Every other read of this setting in the script already uses -master, which does see those defaults.

So a board default like global.videooutput2=none (meaning "don't auto-pick a second output") gets missed here, and the code picks one anyway.

Confirmed live: with the sysconfig default in place and no user override, a second output kept getting auto-selected on every restart.

No board upstream sets global.videooutput2=none right now, so this isn't hurting anyone else yet. But any board that wants no second output by default will hit the same problem. Better to fix it now than wait for another board to run into it.

Fix: use -master here too, same as every other read of this setting in the script.

[nadenislamarre]

please dont merge. ill check, but im almost sure this fix is not correct

[nadenislamarre]

i make sense. i read incorrectly the contrary when i read.

[nadenislamarre]

a contrario, i don't get why we take non-master after master:
# Attempt to get video outputs from master settings first
settings_output=$(batocera-settings-get-master global.videooutput)
settings_output2=$(batocera-settings-get-master global.videooutput2)
settings_output3=$(batocera-settings-get-master global.videooutput3)

# If master settings are not found, try the regular settings                                                                                                                                                                      
if [ -z "$settings_output" ] && [ -z "$settings_output2" ] && [ -z "$settings_output3" ]; then
    echo "Standalone: Master video outputs not found, trying default" >> "$log"
    settings_output=$(batocera-settings-get global.videooutput)
    settings_output2=$(batocera-settings-get global.videooutput2)
    settings_output3=$(batocera-settings-get global.videooutput3)
fi

and there are some other places where master should be taken.

[nadenislamarre]

i would prefer something like this one https://github.com/batocera-linux/batocera.linux/pull/16449/changes

@dmanlfc do you remember why you added a non master check after a check ? (while -master lookup in user settings first)

[nadenislamarre]

#16449 merged.
this one can be close.