Skip to content

Import TargetSelection directly and require Home Assistant 2026.1 - #1651

Open
gjohansson-ST wants to merge 2 commits into
basnijholt:mainfrom
gjohansson-ST:target-selection-import
Open

gjohansson-ST wants to merge 2 commits into
basnijholt:mainfrom
gjohansson-ST:target-selection-import

Conversation

@gjohansson-ST

Copy link
Copy Markdown

Import TargetSelection directly and raise the minimum Home Assistant version to 2026.1.

TargetSelectorData was deprecated in Home Assistant 2026.1 in favor of TargetSelection and is removed in home-assistant/core#190100. This integration already imports TargetSelection first, so it keeps working after the removal; the TargetSelectorData fallback only applies to Home Assistant versions before 2026.1.

This drops the fallback in hass_utils.py, adds TargetSelection to the existing homeassistant.helpers.target import, raises the minimum in hacs.json from 2025.9.0 to 2026.1.0, and removes the 2025.9–2025.12 entries from the pytest matrix, since those versions no longer have a supported import.

ruff check and ruff format --check report nothing for the changed module. I could not run the test suite locally; the pytest matrix covers 2026.1 and later.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The PR changes which Home Assistant versions can use Adaptive Lighting.

The PR appears safe to merge, with non-blocking fixes needed to keep the guide and matrix generator aligned.

Findings

  1. P2 Guide lists the old minimum ▶
  2. P2 Weekly updates restore removed versions ▶

Summary

This PR imports TargetSelection directly and drops support for Home Assistant versions before 2026.1.

  • Adaptive Lighting now requires Home Assistant 2026.1 or newer.

Reviews (1) · Last reviewed commit: "Import TargetSelection directly and requ..." · Reviewed by Greptile

Comment thread hacs.json Resolved
Comment thread .github/workflows/pytest.yaml Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant