This repository was archived by the owner on Aug 23, 2026. It is now read-only.
Repository navigation
Bump livery 0.4.4 + h1 0.7.0; un-skip 3 body-drain smoke tests - #66
Merged
Merged
Conversation
livery 0.4 adds early-response inbound drain on HTTP/1.1: a handler that commits a response before the body is fully read now drains the leftover inbound before closing, so the client reads the response instead of a connection reset. Un-skips: accepts_body_above_cowboy_default_length messages_413_returns_request_too_large_type responses_413_returns_request_too_large_type Resolves: livery 0.3.0 -> 0.4.4, h1 0.6.2 -> 0.7.0, h2 0.10.1 -> 0.10.2, hackney 4.4.0 -> 4.4.5, barrel_mcp 2.2.3 -> 2.2.4.
Wires max_request_body_bytes into the livery HttpOpts so over-cap
uploads trip livery's listener-level abort_body, which keeps the h1
stream alive for early-response drain. Without this, the cap was only
enforced via livery_body:read_all/3 Max in the handler, bypassing the
adapter's drain handshake and letting the client see {error, closed}
before reading the 413.
livery_service's listener_opts type spec doesn't expose `max_body' yet (livery_h1's listen_opts does, and maps:merge forwards it), so dialyzer flags livery:start_service/1 as no-return.
livery 0.4.x does not propagate `max_body_size' down to h1's parser, which keeps its 8 MiB default and trips `client_reset' on bodies > 8 MiB before livery's listener cap + early-response drain can engage. Re-skip with a clear upstream pointer; ship the dep bump (livery 0.4.4, h1 0.7.0, h2 0.10.2, hackney 4.4.5, barrel_mcp 2.2.4, instrument 1.1.4) without the 3 unskips. See docs/livery_forward_max_body_size_prompt.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accepts_body_above_cowboy_default_length,messages_413_returns_request_too_large_type,responses_413_returns_request_too_large_type. The clients now read the 4xx/413 instead ofsocket_closed_remotely.Notes
{full, _, _, _}responses where the inbound body is not atend_stream. Defaults match what the cap test expects (12 MiB body cap vs. 13 MiB POST).docs/for reference.