Repository navigation
fix(cloudformation): do not register plaintext or txt in document selector - #8868
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
…ector Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CloudFormation language server previously registered
{ language: 'plaintext' }and{ pattern: '**/*.txt' }inCfnDocumentSelector. As a result, the CloudFormation language server attached to ordinary notes, log files, and text documents in VS Code. When pressing Enter in any.txtor Plain Text document, the completion widget opened withAWSTemplateFormatVersion: "2010-09-09"preselected, causing subsequent Enter presses to auto-insert CloudFormation template syntax into non-template text files.Solution
Remove
{ language: 'plaintext' }and{ pattern: '**/*.txt' }fromCfnDocumentSelector. The language server continues to attach to genuine template files and extensions (.template,.cfn,.json,.yaml,.yml, andcloudformation/template/json/yamllanguage modes). Also update the unit tests inlspClientConfig.test.tsto reflect the template extensions and verify that plaintext and.txtfiles are not registered.Fixes #8867