Repository navigation
Conversation
geedo0
added this pull request to stack #3663
October 16, 2026 17:21
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/provider-errors #3662 +/- ##
=====================================================
Coverage 78.71% 78.71%
=====================================================
Files 705 705
Lines 130757 130757
Branches 17922 17923 +1
=====================================================
Hits 102920 102920
- Misses 26857 26858 +1
+ Partials 980 979 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
🔒 Security Review — View Report Please review before merging. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context and motivation
The Amazon Linux
aws-lcRPM spec could not build the provider as a subpackage.AWSLC_PROVIDER_OPENSSL_ROOTwas an install prefix, so a distro passing/usr/includehad it searched as/usr/include/include, and the provider had noinstall()rule, so a%filesentry for the module could never be satisfied.Description of changes
find_package(OpenSSL).AWSLC_PROVIDER_OPENSSL_ROOTis removed in favor of the standardOPENSSL_ROOT_DIRhint. Unset, system paths are searched, which is theopenssl-develcase.OPENSSL_ROOT_DIRis treated as exclusive on every CMake.FindOpenSSLhonors the root exclusively only on recent CMake. On 3.22 it falls back to system paths and skipslib64, which compiled the provider against pinned 3.5 headers while linking the system 3.0 libcrypto. When the root is set, the provider resolves the include directory and libcrypto under it first and fails if either is missing.OPENSSL_VERSIONfromFindOpenSSL. The previousOPENSSL_VERSION_STRregex could not reject AWS-LC's own headers, which define only the hex number.${CMAKE_INSTALL_LIBDIR}/ossl-modules, overridable through the newAWSLC_PROVIDER_MODULESDIRcache variable. It is relative, so--prefixandDESTDIRwork, and it matches OpenSSL's own default modules directory.Testing
tests/ci/run_aws_lc_provider_tests.sh, which now passes-DOPENSSL_ROOT_DIR.aws-lc-5.2.0-2.amzn2027spec with a provider subpackage buildsaws-lc-provider, which owns/usr/lib64/ossl-modules/awslc.soand picks uplibcrypto-awslc.so.1(AWS_LC_1.0)as an automatic requirement.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Stack created with GitHub Stacks CLI • Give Feedback 💬