Repository navigation
Make the SSL_SHA256 constant non-overlapping with the rest - #3659
Open
aydinmercan wants to merge 1 commit into
Open
aydinmercan wants to merge 1 commit into
aydinmercan wants to merge 1 commit into
Conversation
aydinmercan
had a problem deploying
to
manual-approval
October 15, 2026 10:28 — with 
GitHub Actions
Error
GitHub Actions
Error
aydinmercan
had a problem deploying
to
manual-approval
October 15, 2026 10:29 — with
GitHub Actions
Error
GitHub Actions
Error
justsmth
approved these changes
Oct 15, 2026
Contributor
|
Thanks for catching this! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3659 +/- ##
==========================================
- Coverage 78.70% 78.48% -0.23%
==========================================
Files 705 705
Lines 130758 130755 -3
Branches 17921 17917 -4
==========================================
- Hits 102914 102623 -291
- Misses 26864 27154 +290
+ Partials 980 978 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
torben-hansen
approved these changes
Oct 17, 2026
The internal constant SSL_SHA256 was equivalent to the union of the AEAD and SHA-1 cipherlist, causing the "SHA256" alias to also affect AEADs and ciphers that use SHA-1 when using it with delete or kill operations. Fix this by ensuring all MAC constants correspond to a unique bit index.
aydinmercan
requested a deployment
to
manual-approval
October 17, 2026 14:32 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
aydinmercan
requested a deployment
to
manual-approval
October 17, 2026 14:32 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Addresses #3455
Context and motivation
The internal constant SSL_SHA256 was equivalent to the union of the AEAD and SHA-1 cipherlist, causing the "SHA256" alias to also affect AEADs and ciphers that use SHA-1 when using it with delete or kill operations.
Found while running the system tests of BIND9 using AWS-LC.
HIGH:-SHA256:-SHA384would remove all ciphers since-SHA256would also remove TLS ciphers with AEADS and HMAC with SHA-1.Description of changes
Change the MAC constants to be non-overlapping
Testing
I don't think adding more non-AEAD ciphers are in consideration for AWS-LC so new tests might not be necessary.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.