Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const bool tls13 = !is_dtls() && version() == TLS1_3_VERSION; | ||
| EXPECT_EQ(!tls13, g_last_session != nullptr); | ||
| EXPECT_EQ(tls13 && flush, BIO_pending(SSL_get_rbio(client_.get())) != 0); | ||
| char buf; |
Contributor
There was a problem hiding this comment.
warning: variable 'buf' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| char buf; | |
| char buf = 0; |
| ASSERT_TRUE(Connect()); | ||
| EXPECT_FALSE(SSL_in_init(server_.get())); | ||
| EXPECT_EQ(0u, BIO_pending(SSL_get_rbio(client_.get()))); | ||
| char buf; |
Contributor
There was a problem hiding this comment.
warning: variable 'buf' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| char buf; | |
| char buf = 0; |
| continue; | ||
| } | ||
|
|
||
| char buf; |
Contributor
There was a problem hiding this comment.
warning: variable 'buf' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| char buf; | |
| char buf = 0; |
Contributor
|
🔒 Security Review — View Report Please review before merging. |
justsmth
force-pushed
the
tls13-flush-tickets-mode
branch
from
October 12, 2026 18:06
1bd8c0e to
3d46006
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3646 +/- ##
==========================================
+ Coverage 78.47% 78.73% +0.26%
==========================================
Files 705 705
Lines 130687 130792 +105
Branches 17913 17932 +19
==========================================
+ Hits 102557 102983 +426
+ Misses 27152 26832 -320
+ Partials 978 977 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
justsmth
force-pushed
the
tls13-flush-tickets-mode
branch
from
October 12, 2026 20:52
3d46006 to
cc9979e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
Context and motivation
Client-speaks-first protocols can stall on Nagle plus delayed ACK while tickets wait for a server write.
Description of changes
Add opt-in
SSL_MODE_FLUSH_TLS13_TICKETSto flush tickets before handshake completion, including normal write backpressure and failures.Testing
Debug build, targeted/full SSL unit and runner suites, and documentation generation passed.
Review considerations
Adds a public mode macro, no symbols. Defaults unchanged; outside the FIPS boundary.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.