Repository navigation
Conversation
Contributor
|
🔒 Security Review — View Report Please review before merging. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3631 +/- ##
==========================================
+ Coverage 78.46% 78.58% +0.12%
==========================================
Files 705 705
Lines 130585 130919 +334
Branches 17906 17934 +28
==========================================
+ Hits 102460 102883 +423
+ Misses 27149 27052 -97
- Partials 976 984 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
justsmth
force-pushed
the
jitter-adaptive-osr
branch
from
October 8, 2026 17:13
f50548b to
f6e491a
Compare
CPU Jitter failures on coarse-timer platforms can terminate applications (aws#3604). Give non-FIPS builds an explicit Jitter-with-OS-fallback configuration: retry at higher oversampling rates, then permanently use OS entropy if recovery fails. Centralize source selection and recovery policy in entropy_sources.c. The tree consumes its configured root provider and aborts if that provider cannot supply a seed, without choosing alternative sources or embedding FIPS-specific behavior. Preserve default-rate Jitter retries in FIPS, omit FIPS failure-injection hooks, and retain VM UBE and build-time opt-out precedence. FIPS_is_entropy_cpu_jitter reports the active root, returning zero after fallback. Fallback loses Jitter as an independent source; without hardware RNG support, randomness relies on OS entropy alone. Cover startup and reseed failures, partial-output replacement, cross-thread persistence, and silent recovery. Testing: macOS non-FIPS, shared-FIPS, and Jitter-disabled builds; Linux x86-64 non-FIPS and static FIPS; Windows MSVC non-FIPS; GCC 4.8 normal/FIPS syntax checks. With a quantized 2 MHz clock, 200 FIPS process starts never fell back to OS entropy and 200 non-FIPS starts never aborted.
justsmth
force-pushed
the
jitter-adaptive-osr
branch
from
October 8, 2026 19:17
f6e491a to
fc9d1a0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Addresses #3604.
Context and motivation
CPU Jitter failures can abort applications on platforms with coarse timers.
Description of changes
Non-FIPS builds select an explicit policy that retries Jitter at higher oversampling rates, then permanently falls back to OS entropy. Source policy stays in
entropy_sources.c; FIPS retains its existing retry and abort behavior.Testing
Failure-injection tests, macOS/Linux/Windows builds, and GCC 4.8 syntax checks; 200 non-FIPS process starts without aborts using a simulated 2 MHz clock.
Review considerations
Fallback loses Jitter as an independent source, leaving only OS entropy without hardware RNG support;
FIPS_is_entropy_cpu_jitter()returns zero afterward.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.