fix: enforce CEK algorithm binding on Kms+Context decrypts - #204
Open
akareddy04 wants to merge 8 commits into
Open
fix: enforce CEK algorithm binding on Kms+Context decrypts #204akareddy04 wants to merge 8 commits into
akareddy04 wants to merge 8 commits into
Conversation
…/V3 downgraded to CBC
- Add CONTENT_CIPHER_TO_ALGORITHM_SUITE and reverse map as single source of truth - KmsKeyring CEK-alg binding check uses the reverse map; fail closed when no suite - Restrict V3 (key-committing) binding tests to improved clients; V2 runs on all - Strip all V3-only headers when tampering V3->V2 CBC so the binding check is the sole defense - Fix default-enc-ctx test to use a realistic stored aws:x-amz-cek-alg - Bump specification submodule to CEK-alg binding requirement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
When decrypting using Kms+Context mode, the KmsKeyring MUST validate that the content encryption algorithm in the KMS-authenticated encryption context matches the algorithm suite selected for decryption.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.