fix(test): address failing windows test by standardizing line endings#1758
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #1758 +/- ##
===========================================
Coverage ? 93.59%
===========================================
Files ? 115
Lines ? 6681
Branches ? 0
===========================================
Hits ? 6253
Misses ? 428
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8037628 to
eb1e977
Compare
eb1e977 to
047401b
Compare
avi-alpert
approved these changes
Jul 16, 2026
AlexanderRichey
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on #1748
Problem
Windows tests are failing #1751.
Root Cause
When the CI runner checks out the repo on windows, its changing the
\nat the end of line to\r\nto be windows friendly (crlf). However, this causes the tests to fail when comparing results against golden files, which now include extra\rat the end of each line.Solution
Normalize line endings on each commit, and on each checkout via
.gitattributes.From docs here https://git-scm.com/docs/gitattributes#_end_of_line_conversion:
We set
text=autoto ensure windows developers cannot commit code with lines following crlf, andeol=lfto ensure that checkouts on windows leverage thelfformat and don't attempt to reformat.Testing
I do not have a windows laptop readily available, but this tests are now passing in CI with the fix.