Skip to content

Htmlpage - #3

Open
awais627 wants to merge 8 commits into
masterfrom
htmlpage
Open

Htmlpage#3
awais627 wants to merge 8 commits into
masterfrom
htmlpage

Conversation

@awais627

Copy link
Copy Markdown
Owner

Simple Html page

Comment thread index.html Outdated
</head>

<body>
<section class="section1 container">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid use of multiple classes and come up with a generic solution for the sections.

Comment thread style.css Outdated
Comment on lines +3 to +8
padding-right: 0.75rem;
padding-right: var(--bs-gutter-x,.75rem);
padding-left: 0.75rem;
padding-left: var(--bs-gutter-x,.75rem);
margin-right: auto;
margin-left: auto;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove redundant classes and use better approach
Suggestion : use flex.

Comment thread style.css Outdated
}
.section1-para{
text-align: center;
padding: 0rem 9rem 3rem 9rem;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does using "0rem" is correct way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants