Converting js to tsx and using types - #2
Open
awais627 wants to merge 3 commits into
Open
Conversation
omair445
suggested changes
May 26, 2022
Comment on lines
+9
to
+12
| "@types/jest": "^27.5.1", | ||
| "@types/node": "^17.0.35", | ||
| "@types/react": "^18.0.9", | ||
| "@types/react-dom": "^18.0.5", |
There was a problem hiding this comment.
Why you have added these packages is typescript dependent on it.
| import Home from "./components/Home"; | ||
|
|
||
| function App() { | ||
| function App():JSX.Element{ |
There was a problem hiding this comment.
Avoid using generic types and use proper type.
Comment on lines
+4
to
+6
| type HandleChange={ | ||
| handleChange:any; | ||
| } |
| type HandleChange={ | ||
| handleChange:any; | ||
| } | ||
| const Filters:FC<HandleChange> = ({ handleChange }) => { |
There was a problem hiding this comment.
Make a separate interface fort the props that you pass to components.
| import React, { FC } from "react"; | ||
| import "./Table.css"; | ||
| const Table = ({ currentPage, post, setCurrentPage }) => { | ||
| type Props = { |
| type Props = { | ||
| currentPage: number; | ||
| post: { | ||
| id: number; |
There was a problem hiding this comment.
Make separate interfaces for nested objects.
| }[]; | ||
| setCurrentPage: any; | ||
| }; | ||
| const Table: FC<Props> = ({ currentPage, post, setCurrentPage }) => { |
There was a problem hiding this comment.
This type is wrong. Please use the correct type.
| @@ -0,0 +1,105 @@ | |||
| { | |||
added 2 commits
May 26, 2022 19:43
omair445
suggested changes
May 30, 2022
| type filters={ | ||
|
|
||
| export interface IFilters { | ||
| beerName: String |
There was a problem hiding this comment.
Why you are using "String" instead of "string"?
| abv: string; | ||
| }[]; | ||
| post: IPostdata[]; | ||
| setCurrentPage: any; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API integration with Typescript