Repository navigation
ci: release the distributions CI built, and pin every action by commit - #65
Merged
Merged
Conversation
publish.yml calls ci.yml on the commit it releases, so the gates, the Orbax-floor checkpoint tests and the derived-status check all pass first, and each index receives the gates' artifact python-package-distributions instead of a second build. ci.yml gains workflow_call for this. A target=github-release run must start from its tag, since CI builds the run's ref; the release-tag step refuses any other ref. RELEASING.md gives the gh command. softprops/action-gh-release, pypa/gh-action-pypi-publish, download-artifact and the macOS checkout are pinned by commit. The pin test moves to test_ci_entry.py and covers every workflow and composite action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish.ymlnow runs CI on the commit it releases and publishes the distributions CI's gates built, not a second build of its own.validatecallsci.yml, which gainsworkflow_call, so the gates, the Orbax-floor checkpoint tests and the derived-status check all pass before anything publishes.publish-testpypiandpublish-pypidownloadpython-package-distributions, the artifact the gates' Build job uploads aftertwine checkand the import check. publish.yml's own build job is gone.target=github-releaserun must be started from its tag (gh workflow run publish.yml --ref vX.Y.Z ...). CI builds the run's ref, so the release-tag step refuses a run from any other ref. RELEASING.md step 8 gives the command.softprops/action-gh-release(v3.0.3),pypa/gh-action-pypi-publish(v1.14.2),download-artifact(v8.0.2) and the macOS checkout are pinned by commit. The pin test moves totest_ci_entry.pyand now reads every workflow and composite action.Trusted publishing is unchanged: the upload jobs are still in
publish.ymland still use thepypiandtestpypienvironments.Checked locally:
tests/ci(145 passed, red first with 9 failures and then the tag-ref test),pre-commit run --all-files, and actionlint 1.7.12 with shellcheck 0.11.0 (a planted SC2086 control failed as expected).Not exercised: an actual publish run. The first release after this merges is the end-to-end check.