fix: report TAP timeouts without crashing - #3471
Open
tianrking wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
writeTimeout()created a nativeErrorand passed it directly todumpError(), which expects AVA's serialized error record. The raw error has nooriginalError, so the formatter throws while assigning its stack and the reporter surfaces anAggregateError.Fixes #3461
Validation
npx tap test-tap/reporters/tap.js(Node 24; 6 subtests passed)npx xo lib/reporters/tap.js test-tap/reporters/tap.jsgit diff --checknpm testinvokes a Bash script that cannot run under this Windows PowerShell checkout; the available WSL distribution has no Node runtime. A direct full lint/typecheck also exposes existing fixture/symlink resolution failures outside this change, while the affected reporter test and target lint pass.