Fix noesc borrow - #1534
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e33393151
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| LayoutBackingProjection::Index(Some(_)), | ||
| LayoutBackingProjection::Index(None) | ||
| | LayoutBackingProjection::IndexFamily(_) |
There was a problem hiding this comment.
When an array of borrow-containing elements comes from a call, its held loan is represented by an IndexFamily; on values[0] = replacement, this exception retains that symbolic loan alongside the new exact entry. effective_loans subsequently expands the retained loan to every original target without applying definite_overrides, so the overwritten referent remains falsely borrowed—for example, forwarding [Wrap; 2], replacing slot 0, and then borrowing the original slot-0 value reports a conflict. Preserve the family loan for sibling indices, but shadow its overwritten member when computing active targets.
Useful? React with 👍 / 👎.
4e33393 to
9094891
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90948911b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Fix borrow checking for aggregates containing
reformutvalues across function calls.This preserves borrow identity through aggregate construction, projection, returns, and stores; handles array overwrites and reborrows precisely; and distinguishes storage views from actual borrows.