Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some actors are run by a plugin, like the cluster singleton or a virtual actor. The plugin can stop such an actor and start it again, possibly on another node. Each time, the actor gets a new
ActorID.So holding an
ActorIDisn't enough: once the plugin restarts the actor, calls to the old ID fail. Callers need a reference that the plugin always routes to the actor that's running now.The singleton plugin builds such references with
interceptCalls, but:interceptCallsis internal, so plugins outsideDistributedClustercan't use it;What changed
All additive. Existing behaviour is unchanged.
RemoteCallInterceptorandinterceptCalls(to:metadata:interceptor:)are public.interceptCallsno longer ignores itsmetadata.forwardCall(to: ActorID, …)/forwardCallVoiddeliver a call to an actor by ID, locally or remotely.ClusterSystemSettings.propagateMetadata(\.key)opts a metadata key into travelling with IDs. It also fixes custom metadata being dropped byActorID.init(from:).ActorLifecyclePlugin.interceptor(for:)(defaultnil) lets a plugin intercept IDs it recognises when they're decoded on another node.Result
cluster-virtual-actors'
getActorreturns such a reference. A reference kept on another node keeps working after the actor is deactivated: the next call starts the actor again and reaches it. If the actor can't be started, for example because no node hosts virtual actors, the call fails with that error.Open questions