Improve testing and documentation for server firewall marks#13385
Open
JosiahWI wants to merge 5 commits into
Open
Improve testing and documentation for server firewall marks#13385JosiahWI wants to merge 5 commits into
JosiahWI wants to merge 5 commits into
Conversation
JosiahWI
force-pushed
the
feat/fwmark-server-side-test
branch
from
July 16, 2026 14:55
40edfc4 to
eafd2a7
Compare
JosiahWI
marked this pull request as ready for review
July 16, 2026 14:55
ezelkow1
self-requested a review
July 16, 2026 14:58
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the server-side counterpart to the existing client-side firewall mark test, plus clarifies documentation for TSHttpTxnServerPacketMarkSet, keeping the client/server packet mark APIs consistent and better specified.
Changes:
- Add a new test plugin (
server_packet_mark) to exercise both the “apply to live origin connection” and “seed for future origin connection” behaviors. - Extend the existing AuTest to validate both
TSHttpTxnClientPacketMarkSetandTSHttpTxnServerPacketMarkSetvia SO_MARK readback. - Update API documentation (header + Sphinx doc) to clarify semantics, platform behavior, and return value expectations.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/tools/plugins/server_packet_mark.cc | New server-side packet mark test plugin exercising live + preconnect paths. |
| tests/tools/plugins/packet_mark_common.h | Add server-side helper declarations; refine shared helper description. |
| tests/tools/plugins/packet_mark_common.cc | Implement server-side helper wrappers for mark set + echo. |
| tests/tools/plugins/CMakeLists.txt | Build the new server_packet_mark AuTest plugin. |
| tests/gold_tests/pluginTest/packet_mark/packet_mark.test.py | Expand test to cover both client/server marks and add the preconnect seeding case. |
| include/ts/ts.h | Clarify TSHttpTxnServerPacketMarkSet contract in the public API header. |
| doc/developer-guide/api/functions/TSHttpTxnServerPacketMarkSet.en.rst | Improve server packet mark API documentation and remove incomplete text. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the server-side test to complement the client-side test in #13383.