RANGER-5773: Harden encryption of stored service configuration secrets - #1208
Open
vyommani wants to merge 1 commit into
Open
RANGER-5773: Harden encryption of stored service configuration secrets#1208vyommani wants to merge 1 commit into
vyommani wants to merge 1 commit into
Conversation
vyommani
requested review from
dineshkumar-yadav,
mneethiraj and
pradeepagrawal8184
September 3, 2026 11:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Strengthens how Ranger Admin protects certain encrypted configuration values (e.g. service
connection passwords) at rest, and migrates existing data to the improved approach. New writes
get the improved protection immediately; a one-time patch upgrades data written before this
change.
How was this patch tested?
Ran end-to-end against a real running instance (
dev-support/ranger-docker), not just unittests, using genuine legacy-format data:
pre-migration value (confirms a real decrypt/re-encrypt, not a relabel); zero failures.
fails closed with an actionable error instead of a silent bad-password auth failure; reverting
the key restores correct decryption.
failures.
mvn test/ project build verification is still pending — this pass was done in anenvironment without Maven Central access, so verification so far is against the modified
classes compiled and run directly, not through the project's own build.
Open questions for reviewers (flagged in-code, not silently decided)
codebase) — acceptable at very large scale, or should it batch?
failing it outright, to avoid turning a legitimate transient state (e.g. an in-progress key
rotation) into an outage. Right trade-off, or should a hard mismatch block startup?
rather than repeating the existing byte-exact re-encrypt-and-compare self-check the legacy
branches use. Is that reliance justified as-is?