Fix AassertTrue/assertFalse simplified regarding the report from sona…#6725
Open
dawidkwiecien wants to merge 4 commits into
Open
Fix AassertTrue/assertFalse simplified regarding the report from sona…#6725dawidkwiecien wants to merge 4 commits into
dawidkwiecien wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Sonar Qube issue (Java) JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
https://sonarcloud.io/project/issues?rules=java%3AS5785&issueStatuses=OPEN%2CCONFIRMED&id=JMeter
Additionaly in PackageTest.java, I've removed self-assertions for example AssertEquals(a1,a1) which were useless.
Motivation and Context
Remove issue from SonarQube
How Has This Been Tested?
I've runned ./gradlew test and there is no issue
Screenshots (if appropriate):
Types of changes
Checklist: