Skip to content

OpenAPI: Remove deprecated TrueExpression and FalseExpression (#18351) #18431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhang-arvin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OpenAPI: Remove deprecated TrueExpression and FalseExpression (#18351) #18431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 0 additions & 72 deletions open-api/rest-catalog-open-api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,74 +155,6 @@ class ExpressionType(RootModel[str]):
)


class TrueExpression(BaseModel):
"""
Deprecated. Use the bare boolean literal `true` as a predicate instead.

"""

type: Literal['true'] = Field(
...,
examples=[
[
'true',
'false',
'eq',
'and',
'or',
'not',
'in',
'not-in',
'lt',
'lt-eq',
'gt',
'gt-eq',
'not-eq',
'starts-with',
'not-starts-with',
'is-null',
'not-null',
'is-nan',
'not-nan',
]
],
)


class FalseExpression(BaseModel):
"""
Deprecated. Use the bare boolean literal `false` as a predicate instead.

"""

type: Literal['false'] = Field(
...,
examples=[
[
'true',
'false',
'eq',
'and',
'or',
'not',
'in',
'not-in',
'lt',
'lt-eq',
'gt',
'gt-eq',
'not-eq',
'starts-with',
'not-starts-with',
'is-null',
'not-null',
'is-nan',
'not-nan',
]
],
)


class IdReference(BaseModel):
"""
A bound reference to a field by field ID.
Expand Down Expand Up @@ -2340,8 +2272,6 @@ class Type(RootModel[VariantType | PrimitiveType | StructType | ListType | MapTy
class Predicate(
RootModel[
bool
| TrueExpression
| FalseExpression
| AndOrPredicate
| NotPredicate
| UnaryPredicate
Expand All @@ -2351,8 +2281,6 @@ class Predicate(
):
root: (
bool
| TrueExpression
| FalseExpression
| AndOrPredicate
| NotPredicate
| UnaryPredicate
Expand Down
26 changes: 0 additions & 26 deletions open-api/rest-catalog-open-api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2547,8 +2547,6 @@ components:
Predicate:
oneOf:
- type: boolean
- $ref: '#/components/schemas/TrueExpression'
- $ref: '#/components/schemas/FalseExpression'
- $ref: '#/components/schemas/AndOrPredicate'
- $ref: '#/components/schemas/NotPredicate'
- $ref: '#/components/schemas/UnaryPredicate'
Expand Down Expand Up @@ -2586,30 +2584,6 @@ components:
- $ref: '#/components/schemas/Reference'
- $ref: '#/components/schemas/Apply'

TrueExpression:
deprecated: true
description: >
Deprecated. Use the bare boolean literal `true` as a predicate instead.
type: object
required:
- type
properties:
type:
$ref: '#/components/schemas/ExpressionType'
const: "true"

FalseExpression:
deprecated: true
description: >
Deprecated. Use the bare boolean literal `false` as a predicate instead.
type: object
required:
- type
properties:
type:
$ref: '#/components/schemas/ExpressionType'
const: "false"

AndOrPredicate:
type: object
required:
Expand Down
Loading