Flink: Fix DynamicIcebergSink writing NULLs for case-mismatched columns - #18066
Open
mithun-sudo wants to merge 3 commits into
Open
Flink: Fix DynamicIcebergSink writing NULLs for case-mismatched columns#18066mithun-sudo wants to merge 3 commits into
mithun-sudo wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
caseSensitive(false)can write NULL for columns whose names differ only by case.CompareSchemasVisitormatches names case-insensitively and returnsDATA_CONVERSION_NEEDED, butDataConverterusedRowType.getFieldIndex(exact match), so the source field looked missing.caseSensitiveintoDataConverterand look up fields withequalsIgnoreCasewhen matching is case-insensitive.Test plan
TestRowDataConvertercase-insensitive remap (values kept, missing optional field is null)TestDynamicIcebergSink.testCaseInsensitiveDataConversionDropsValues./gradlew :iceberg-flink:iceberg-flink-2.3:test -DflinkVersions=2.3 --tests org.apache.iceberg.flink.sink.dynamic.TestRowDataConverter --tests org.apache.iceberg.flink.sink.dynamic.TestDynamicIcebergSink.testCaseInsensitiveDataConversionDropsValues