AWS: Add S3 API call timeout configuration for S3Client and S3AsyncClient - #18064
Open
flysen wants to merge 2 commits into
Open
AWS: Add S3 API call timeout configuration for S3Client and S3AsyncClient#18064flysen wants to merge 2 commits into
flysen wants to merge 2 commits into
Conversation
S3 write calls (putObject, multipart upload) block synchronously with no timeout — a stalled connection can hang the calling thread indefinitely with no exception or log output. Add s3.api-call-timeout-ms and s3.api-call-attempt-timeout-ms, wired to the SDK's ClientOverrideConfiguration, so a stalled call throws instead of hanging silently. Off by default; only active if configured.
testDefaultS3FileIOAwsClientFactoryAppliesApiCallTimeoutToAsyncClient builds a real S3AsyncClient via serviceClientConfiguration(), which requires resolving an AWS region. CI runners have no AWS_REGION/ profile configured, so the build failed with SdkClientException. Set client.region explicitly in the test properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 write calls (putObject, multipart upload) block synchronously with no timeout — a stalled connection can hang the calling thread indefinitely with no exception or log output. Add
s3.api-call-timeout-msand s3.api-call-attempt-timeout-ms, wired to the SDK's ClientOverrideConfiguration, so a stalled call throws instead of hanging silently. Off by default; only active if configured.