Build: Fix Spark publication and CI configuration - #18042
Merged
Conversation
Avoid republishing unrelated snapshot artifacts and preserve complete release BOM constraints. Correct stale benchmark workflow filters and clarify the supported Spark matrix. Generated-by: Codex
Generated-by: Codex
Keep dev/stage-binaries.sh unchanged in this PR. Generated-by: Codex
manuzhang
marked this pull request as ready for review
September 11, 2026 04:28
uros-b
approved these changes
Sep 11, 2026
Member
|
Looks good, thank you @manuzhang! |
szehon-ho
approved these changes
Sep 11, 2026
szehon-ho
left a comment
Member
There was a problem hiding this comment.
lgtm but im not the expert, will see if any other comments and merge if none
kevinjqliu
approved these changes
Sep 12, 2026
| ./gradlew printVersion | ||
| ./gradlew -DallModules publishApachePublicationToMavenRepository -PmavenUser="$NEXUS_USER" -PmavenPassword="$NEXUS_PW" | ||
| ./gradlew -DflinkVersions= -DsparkVersions=3.5,4.0 -DscalaVersion=2.13 -DkafkaVersions=3 publishApachePublicationToMavenRepository -PmavenUser="$NEXUS_USER" -PmavenPassword="$NEXUS_PW" | ||
| ./gradlew -DflinkVersions= -DsparkVersions=3.5 -DscalaVersion=2.13 -DkafkaVersions= \ |
Contributor
There was a problem hiding this comment.
I see, so the first ./gradlew -DallModules command publishes all the packages and uses the default 2.12 scala.
Spark 3.5 is the odd one out, it needs to publish package for both 2.12 and 2.13
Lines 1257 to 1263 in cff60bc
So this second command publishes explicitly for Spark 3.5 with 2.13
Member
Author
There was a problem hiding this comment.
The first command publishes with default 2.12 for 3.5 and 2.13 for 4+.
Comment on lines
+1264
to
+1265
| "4.0": ["2.13"], | ||
| "4.1": ["2.13"], |
Contributor
There was a problem hiding this comment.
this is a separate BOM issue.
nssalian
approved these changes
Sep 12, 2026
Contributor
|
Thanks @manuzhang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The supplemental snapshot publication repeats publication of common modules, Kafka Connect, and Spark 4.0 artifacts already covered by the all-modules pass. Limit it to the three additional Spark 3.5/Scala 2.13 artifacts: integration, extensions, and runtime.
Add Spark 4.0 and 4.1/Scala 2.13 entries to the BOM so consumers can use its version constraints for those artifacts. Keep Spark 4.2 excluded from the release BOM.
Correct stale JMH workflow paths in CI filters and align Spark matrix comments with the configuration they describe.
Validation
./gradlew spotlessCheckgit diff --checkAI Disclosure