Skip to content

Build: Fix Spark publication and CI configuration - #18042

Merged
kevinjqliu merged 3 commits into
mainfrom
ci-fix-spark-release-config
Sep 12, 2026
Merged

Build: Fix Spark publication and CI configuration#18042
kevinjqliu merged 3 commits into
mainfrom
ci-fix-spark-release-config

Conversation

@manuzhang

@manuzhang manuzhang commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary

The supplemental snapshot publication repeats publication of common modules, Kafka Connect, and Spark 4.0 artifacts already covered by the all-modules pass. Limit it to the three additional Spark 3.5/Scala 2.13 artifacts: integration, extensions, and runtime.

Add Spark 4.0 and 4.1/Scala 2.13 entries to the BOM so consumers can use its version constraints for those artifacts. Keep Spark 4.2 excluded from the release BOM.

Correct stale JMH workflow paths in CI filters and align Spark matrix comments with the configuration they describe.

Validation

  • ./gradlew spotlessCheck
  • Dry-run of the three supplemental snapshot publication tasks
  • Generated the all-modules BOM and verified Spark constraint counts
  • Parsed all 23 GitHub workflow YAML files
  • git diff --check

AI Disclosure

  • Model: GPT-5 (initial changes, as previously recorded); GPT-6 (follow-up edits and description)
  • Platform/Tool: Codex
  • Human Oversight: partially reviewed
  • Prompt Summary: Fix Spark snapshot publication, release BOM entries, and CI configuration; remove the outdated Java 21 comment and keep dev/stage-binaries.sh unchanged.

Avoid republishing unrelated snapshot artifacts and preserve complete release BOM constraints. Correct stale benchmark workflow filters and clarify the supported Spark matrix.

Generated-by: Codex
Keep dev/stage-binaries.sh unchanged in this PR.

Generated-by: Codex
@manuzhang
manuzhang marked this pull request as ready for review September 11, 2026 04:28
@uros-b

uros-b commented Sep 11, 2026

Copy link
Copy Markdown
Member

Looks good, thank you @manuzhang!

@szehon-ho szehon-ho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but im not the expert, will see if any other comments and merge if none

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

./gradlew printVersion
./gradlew -DallModules publishApachePublicationToMavenRepository -PmavenUser="$NEXUS_USER" -PmavenPassword="$NEXUS_PW"
./gradlew -DflinkVersions= -DsparkVersions=3.5,4.0 -DscalaVersion=2.13 -DkafkaVersions=3 publishApachePublicationToMavenRepository -PmavenUser="$NEXUS_USER" -PmavenPassword="$NEXUS_PW"
./gradlew -DflinkVersions= -DsparkVersions=3.5 -DscalaVersion=2.13 -DkafkaVersions= \

@kevinjqliu kevinjqliu Sep 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so the first ./gradlew -DallModules command publishes all the packages and uses the default 2.12 scala.

Spark 3.5 is the odd one out, it needs to publish package for both 2.12 and 2.13

iceberg/build.gradle

Lines 1257 to 1263 in cff60bc

// The Iceberg-Build builds for only one Scala version at a time, so the BOM would also
// only contain artifacts for that single Scala version. The following code ensures that
// the BOM references the artifacts for all Scala versions.
def sparkScalaPattern = ~"(.*)-([0-9][.][0-9]+)_([0-9][.][0-9]+)"
def sparkScalaVersions = [
"3.5": ["2.12", "2.13"],
]

So this second command publishes explicitly for Spark 3.5 with 2.13

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first command publishes with default 2.12 for 3.5 and 2.13 for 4+.

Comment thread build.gradle
Comment on lines +1264 to +1265
"4.0": ["2.13"],
"4.1": ["2.13"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a separate BOM issue.

@kevinjqliu
kevinjqliu merged commit 9299fe6 into main Sep 12, 2026
44 checks passed
@kevinjqliu
kevinjqliu deleted the ci-fix-spark-release-config branch September 12, 2026 20:02
@kevinjqliu

Copy link
Copy Markdown
Contributor

Thanks @manuzhang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants