Repository navigation
fix(parquet): accept Decimal32 and Decimal64 during schema projection - #992
Merged
Merged
Conversation
wgtmac
approved these changes
Oct 10, 2026
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this, @YinZheng-Sun!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parquet schema projection rejects Arrow Decimal32/64, which can come from
smallest_decimal_enabledor storedARROW:schemametadata (apache/arrow#47427).Accept both types through Arrow's common
DecimalTypeinterface, preserving the existing precision and scale checks. Add regression tests for schema projection and reading files with stored Decimal32/64 schemas.Validation (Arrow 25.0.1): 112 Parquet tests passed, 1 skipped; pre-commit and the targeted designated-initializer clang-tidy check passed.
AI assistance: Codex helped implement and test this change.