Repository navigation
fix(cmake): record avro-cpp as system dependency in installed config - #987
Merged
Merged
Conversation
The installed iceberg-config.cmake called find_dependency(Avro), but the package found is avro-cpp, which does not provide an Avro package. Closes apache#973
wgtmac
approved these changes
Oct 9, 2026
Member
|
Thank you, @rohanjain101! BTW, I saw you are maintaining the vcpkg port of iceberg-cpp. Do you want to eliminate all patches there by directly fixing them in this repo? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #973.
When built against a system Avro,
resolve_avro_dependency()appendedAvrotoICEBERG_SYSTEM_DEPENDENCIES, so the installediceberg-config.cmakecalledfind_dependency(Avro). The package actually found isavro-cpp(exportingavro-cpp::avrocpp_*), so consumers'find_package(iceberg CONFIG)failed. This records the real package name.