Deprecate the never-cache-responses-with-query options and HTTP/1.0 response caching - #870
Merged
arturobernalg merged 1 commit intoAug 15, 2026
Conversation
arturobernalg
changed the title
arturobernalg
changed the title
arturobernalg
marked this pull request as ready for review
August 14, 2026 06:11
ok2c
approved these changes
Aug 14, 2026
ok2c
left a comment
ok2c
left a comment
Member
There was a problem hiding this comment.
@arturobernalg Looks good otherwise.
ok2c
requested changes
Aug 14, 2026
arturobernalg
force-pushed
the
cache-deprecate-query-caching
branch
from
August 14, 2026 09:50
bef5243 to
72c777c
Compare
…opt-in Assigning heuristic freshness to a response with a query component is no longer prohibited by the HTTP caching specification. ResponseCachingPolicy now consults the never-cache-query options only when they are explicitly enabled, so in the default configuration a response with a query component is cached like any other. isNeverCacheHTTP10ResponsesWithQuery, isNeverCacheHTTP11ResponsesWithQuery and their builder setters are deprecated, as is HTTP/1.0 response caching. An origin that does not want a response cached should send an explicit directive such as Cache-Control: no-cache.
arturobernalg
force-pushed
the
cache-deprecate-query-caching
branch
from
August 14, 2026 11:32
72c777c to
b3c9784
Compare
ok2c
approved these changes
Aug 14, 2026
Member
|
@arturobernalg I tweaked some of your test case changes to keep the original asserts. I will also port the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the discussion on the query-string heuristic-caching report: assigning heuristic freshness to a response with a query component is no longer prohibited by the HTTP caching specification, so the
CacheConfigoptions that suppress caching of such responses no longer serve a purpose.This deprecates isNeverCacheHTTP10ResponsesWithQuery, isNeverCacheHTTP11ResponsesWithQuery and their builder setters, and deprecates HTTP/1.0 response caching as a whole (noted in the
CacheConfigJavadoc and at the version check inResponseCachingPolicy). Behaviour is unchanged — the options are still honoured — and an origin that does not want a response cached should send an explicit directive such as Cache-Control: no-cache.