HBASE-30256 FuzzyRowFilter mishandles the fuzzy-mask encoding on the …#8412
Open
liuxiaocs7 wants to merge 2 commits into
Open
HBASE-30256 FuzzyRowFilter mishandles the fuzzy-mask encoding on the …#8412liuxiaocs7 wants to merge 2 commits into
liuxiaocs7 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes and hardens FuzzyRowFilter mask handling across the “unsafe” and “no-unsafe” execution paths (including cross-platform / cross-version serialization), ensuring mask semantics are preserved during scanning, hinting, and (de)serialization.
Changes:
- Normalize and stabilize internal mask/key preprocessing in
FuzzyRowFilterso masks are not mutated during scanning and wire format stays platform-independent ({0,1}). - Ensure hinting uses the correct mask semantics on both paths by converting masks as needed without corrupting the satisfy logic.
- Add targeted tests for (a) serialization/equals stability after scanning and (b) end-to-end “no-unsafe” behavior, including interoperability with unsafe-encoded peers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java | Normalizes mask handling, prevents scan-time mutation, converts masks appropriately for satisfies vs hinting, and emits canonical {0,1} masks on serialization; updates equals/hashCode to align with serialized semantics. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilterWoUnsafe.java | New end-to-end tests that force the no-unsafe path and validate matching, hinting (forward/reverse), and interoperability with unsafe-encoded serialized masks. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java | Adds regression tests ensuring serialization and equals/hashCode remain correct even after filterCell has been invoked. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…no-unsafe path