[GLUTEN-12457][FLINK] configure FLINK preset before Velox4j.initialize#12458
Open
ggjh-159 wants to merge 1 commit into
Open
[GLUTEN-12457][FLINK] configure FLINK preset before Velox4j.initialize#12458ggjh-159 wants to merge 1 commit into
ggjh-159 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue: #12457
What changes are proposed in this pull request?
Configures the velox4j
FLINKpreset beforeVelox4j.initialize()in both the production TaskManager and the gluten-flink UT harness.Background: velox4j is adding a
FLINKpreset (sibling to the defaultSPARK) so Flink-flavored SQL function registrations stay isolated from Spark's. The default remainsSPARK, so any caller that wants the Flink behavior mustVelox4j.configure(Preset.KEY, Preset.FLINK)beforeinitialize(). gluten-flink is that caller.Changes
TaskManagerRunner.java—Velox4j.configure(Preset.KEY, Preset.FLINK)immediately beforeVelox4j.initialize()in the Gluten-specific block.Velox4jEnvironment.java— same call in the UT harness constructor.Depends on the upstream velox4j change(bigo-sg/velox4j#54) that introduces the
Presetenum and theio.github.zhztheplayer.velox4j.config.Presetclass.How was this patch tested?
Existing gluten-flink UTs (
Velox4jEnvironmentis the UT init wrapper). End-to-end behavior is verified on the velox4j side byRegexpExtractTestrunning under the FLINK preset.