branch-4.1: [fix](fe) Detect Doris-compatible MySQL JDBC targets #64389#64473
Open
suxiaogang223 wants to merge 1 commit into
Open
branch-4.1: [fix](fe) Detect Doris-compatible MySQL JDBC targets #64389#64473suxiaogang223 wants to merge 1 commit into
suxiaogang223 wants to merge 1 commit into
Conversation
Issue Number: None
Related PR: None
Problem Summary: JDBC catalog initializes the MySQL client as a plain MySQL-compatible target unless the remote version_comment contains the word Doris. Doris-compatible deployments can expose version comments such as SelectDB, VeloDB, or enterprise cloud strings, so Doris-specific column type overrides are skipped. As a result, Doris complex types reported through MySQL metadata can be mapped as scalar MySQL types and fail during scan. This change recognizes Doris-compatible version comments in both the FE core JDBC client and the connector-jdbc MySQL client, keeping the existing SHOW FULL COLUMNS based type override path enabled for compatible endpoints.
Fix JDBC catalog type mapping for Doris-compatible MySQL endpoints whose version_comment does not contain Doris.
- Test: Unit Test
- ./run-fe-ut.sh --run org.apache.doris.datasource.jdbc.client.JdbcMySQLClientTest
- mvn -pl fe-connector/fe-connector-jdbc -am -Dtest=org.apache.doris.connector.jdbc.client.JdbcMySQLConnectorClientTest -DfailIfNoTests=false test
- Behavior changed: Yes. JDBC MySQL catalog now treats SelectDB, VeloDB, and enterprise cloud version comments as Doris-compatible for column type mapping.
- Does this need documentation: No
(cherry picked from commit 6411c70)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #64389
Problem Summary: Pick #64389 to branch-4.1. JDBC catalog initializes the MySQL client as a plain MySQL-compatible target unless the remote version_comment contains the word Doris. Doris-compatible deployments can expose version comments such as SelectDB, VeloDB, or enterprise cloud strings, so Doris-specific column type overrides are skipped. As a result, Doris complex types reported through MySQL metadata can be mapped as scalar MySQL types and fail during scan. This pick recognizes Doris-compatible version comments and keeps using the existing SHOW FULL COLUMNS based type override path.
Note: branch-4.1 does not have the newer fe-connector-jdbc module from master, so this manual pick keeps only the existing fe-core JDBC client and unit test changes.
Release note
Fix JDBC catalog type mapping for Doris-compatible MySQL endpoints whose version_comment does not contain Doris.
Check List (For Author)